Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hero component by removing paddings and increasing width to 100 p… #464

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

lovesitecore
Copy link
Collaborator

fix hero component by removing paddings and increasing width to 100 percent. Also container style has been adjusted by using style items in shared site. (only Hero Homepage Varinat)

Description / Motivation

Hero component showed gaps (padding) on the right depending on image size. Also the text was shifted to the left. The width of the hero component has been set to 100% which looks good on desktop and mobile.

for using Hero component on Generic Page Designs the container used as placeholder has been adjusted as well. I added a style item named zero padding and applied it to the container used on the Generic Page Partial Design.

How Has This Been Tested?

this has been tested on local.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

…ercent. Also container style has been adjusted by using style items in shared site.
@robearlam robearlam merged commit afef90c into main Apr 29, 2024
7 checks passed
@robearlam robearlam deleted the fix-hero-component-design branch April 29, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants